Skip to content

ak-nss: don't log warning and return correct response for not found - #1295

Open
BeryJu wants to merge 1 commit into
mainfrom
ak-nss/fix-warnings
Open

ak-nss: don't log warning and return correct response for not found#1295
BeryJu wants to merge 1 commit into
mainfrom
ak-nss/fix-warnings

Conversation

@BeryJu

@BeryJu BeryJu commented Jul 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.94872% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.46%. Comparing base (4e2a3c8) to head (876d4c1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ak-nss/src/shadow.rs 47.61% 10 Missing and 1 partial ⚠️
ak-nss/src/group.rs 60.00% 6 Missing and 2 partials ⚠️
ak-nss/src/error.rs 72.72% 3 Missing ⚠️
ak-nss/src/passwd.rs 88.46% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   40.57%   39.46%   -1.12%     
==========================================
  Files         158      160       +2     
  Lines       14219    15266    +1047     
  Branches     9229     9304      +75     
==========================================
+ Hits         5769     6024     +255     
- Misses       8337     9123     +786     
- Partials      113      119       +6     
Flag Coverage Δ
rs-e2e 35.12% <55.31%> (-1.07%) ⬇️
rs-macos-26-ak-agent 4.57% <ø> (+0.02%) ⬆️
rs-macos-26-ak-agent-desktop 0.00% <ø> (ø)
rs-macos-26-ak-api-cli-gen 66.71% <ø> (ø)
rs-macos-26-ak-browser-support 23.80% <ø> (ø)
rs-macos-26-ak-cli 12.10% <ø> (ø)
rs-macos-26-ak-platform 0.30% <ø> (-0.02%) ⬇️
rs-macos-26-ak-platform-facts 83.96% <ø> (ø)
rs-macos-26-ak-sysd 34.20% <ø> (+0.08%) ⬆️
rs-ubuntu-24.04-ak-agent 4.57% <ø> (+0.02%) ⬆️
rs-ubuntu-24.04-ak-agent-desktop 0.00% <ø> (ø)
rs-ubuntu-24.04-ak-api-cli-gen 66.71% <ø> (ø)
rs-ubuntu-24.04-ak-browser-support 23.80% <ø> (ø)
rs-ubuntu-24.04-ak-cli 12.10% <ø> (ø)
rs-ubuntu-24.04-ak-nss 74.57% <63.49%> (-3.00%) ⬇️
rs-ubuntu-24.04-ak-pam 0.00% <ø> (ø)
rs-ubuntu-24.04-ak-platform 0.30% <ø> (-0.02%) ⬇️
rs-ubuntu-24.04-ak-platform-facts 83.14% <ø> (ø)
rs-ubuntu-24.04-ak-sysd 34.30% <ø> (+0.09%) ⬆️
rs-ubuntu-24.04-arm-ak-agent 4.57% <ø> (+0.02%) ⬆️
rs-ubuntu-24.04-arm-ak-agent-desktop 0.00% <ø> (ø)
rs-ubuntu-24.04-arm-ak-api-cli-gen 66.71% <ø> (ø)
rs-ubuntu-24.04-arm-ak-browser-support 23.80% <ø> (ø)
rs-ubuntu-24.04-arm-ak-cli 12.10% <ø> (ø)
rs-ubuntu-24.04-arm-ak-nss 74.57% <63.49%> (-3.00%) ⬇️
rs-ubuntu-24.04-arm-ak-pam 0.00% <ø> (ø)
rs-ubuntu-24.04-arm-ak-platform 0.30% <ø> (-0.02%) ⬇️
rs-ubuntu-24.04-arm-ak-platform-facts 83.14% <ø> (ø)
rs-ubuntu-24.04-arm-ak-sysd 34.30% <ø> (+0.09%) ⬆️
rs-windows-2025-ak-agent 4.57% <ø> (+0.02%) ⬆️
rs-windows-2025-ak-agent-desktop 0.00% <ø> (ø)
rs-windows-2025-ak-api-cli-gen 66.71% <ø> (ø)
rs-windows-2025-ak-browser-support 23.80% <ø> (ø)
rs-windows-2025-ak-cli 12.10% <ø> (ø)
rs-windows-2025-ak-platform 0.31% <ø> (-0.02%) ⬇️
rs-windows-2025-ak-platform-facts 79.61% <ø> (ø)
rs-windows-2025-ak-sysd 32.49% <ø> (+0.08%) ⬆️
swift 3.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@authentik-automation

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://pr-1295--authentik-pkg.netlify.app

@authentik-automation
authentik-automation Bot temporarily deployed to pull request July 29, 2026 19:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant