Skip to content

fix: don't report success when JWT secret generation fails #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pucedoteth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't report success when JWT secret generation fails #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,19 @@ services:
jwt-generator:
container_name: giwa-jwt-generator
image: alpine/openssl
entrypoint: >
/bin/sh -c "[ ! -s /shared/jwtsecret.key ] && openssl rand -hex 32 | tr -d '\n' > /shared/jwtsecret.key || exit 0"
entrypoint:
- /bin/sh
- -c
- |
set -e
# Write to a temp file and check it before promoting: a failed openssl
# or a failed write must not leave an absent or empty secret behind,
# and must not report success to service_completed_successfully.
if [ ! -s /shared/jwtsecret.key ]; then
openssl rand -hex 32 | tr -d '\n' > /shared/jwtsecret.key.tmp
[ -s /shared/jwtsecret.key.tmp ]
mv /shared/jwtsecret.key.tmp /shared/jwtsecret.key
fi
volumes:
- shared:/shared
restart: "no"
Expand Down