fix op-reth link: optimism repo has no main branch - #41
Open
Kajko25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The op-reth link in the Execution Client section 404s:
ethereum-optimism/optimismhas nomainbranch — its default isdevelop, so every/tree/main/…URL into that repo fails. The path itself is fine; only the branch name is wrong.Verified against the API rather than the page, because two things mislead here:
GET /repos/ethereum-optimism/optimism/contents/rust/op-reth?ref=developreturns the directory with its 15 entries (bin,crates,DockerfileOp, …), so the target is real.I also checked the obvious-looking alternative,
ethereum-optimism/op-reth, and deliberately did not point the link there: that repository is archived and was last pushed 2025-02-16, so it would trade a broken link for a stale one.No open PR in this repo touches this line. Single word changed, no other edits.