Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion External/libgit2
Submodule libgit2 updated 3210 files
1 change: 1 addition & 0 deletions ObjectiveGit/Categories/NSData+Git.m
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#import "NSError+Git.h"

#import "git2/errors.h"
#import "git2/deprecated.h"

@implementation NSData (Git)

Expand Down
1 change: 1 addition & 0 deletions ObjectiveGit/GTBlame.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

#import <Foundation/Foundation.h>
#import "git2/types.h"
#import "git2/blame.h"

@class GTBlameHunk;
Expand Down
1 change: 1 addition & 0 deletions ObjectiveGit/GTBlameHunk.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

#import <Foundation/Foundation.h>
#import "git2/types.h"
#import "git2/blame.h"

@class GTOID;
Expand Down
2 changes: 1 addition & 1 deletion ObjectiveGit/GTBlob.m
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ - (NSData *)data {
- (NSData *)applyFiltersForPath:(NSString *)path error:(NSError **)error {
NSCParameterAssert(path != nil);

git_buf buffer = GIT_BUF_INIT_CONST(0, NULL);
git_buf buffer = GIT_BUF_INIT;
int gitError = git_blob_filtered_content(&buffer, self.git_blob, path.UTF8String, 1);
if (gitError != GIT_OK) {
if (error != NULL) *error = [NSError git_errorFor:gitError description:@"Failed to apply filters for path %@ to blob", path];
Expand Down
2 changes: 1 addition & 1 deletion ObjectiveGit/GTBranch.m
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ - (GTOID *)OID {
}

- (NSString *)remoteName {
git_buf remote_name = GIT_BUF_INIT_CONST(0, NULL);
git_buf remote_name = GIT_BUF_INIT;
int gitError = git_branch_remote_name(&remote_name, self.repository.git_repository, self.reference.name.UTF8String);
if (gitError != GIT_OK) return nil;

Expand Down
1 change: 1 addition & 0 deletions ObjectiveGit/GTCredential.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//

#import <Foundation/Foundation.h>
#import "git2/deprecated.h"
#import "git2/transport.h"

/// An enum describing the data needed for authentication.
Expand Down
6 changes: 2 additions & 4 deletions ObjectiveGit/GTCredential.m
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,15 @@ int GTCredentialAcquireCallback(git_cred **git_cred, const char *url, const char
GTCredentialProvider *provider = info->credProvider;

if (provider == nil) {
git_error_set_str(GIT_EUSER, "No GTCredentialProvider set, but authentication was requested.");
return GIT_ERROR;
return GIT_EAUTH;
}

NSString *URL = (url != NULL ? @(url) : @"");
NSString *userName = (username_from_url != NULL ? @(username_from_url) : nil);

GTCredential *cred = [provider credentialForType:(GTCredentialType)allowed_types URL:URL userName:userName];
if (cred == nil) {
git_error_set_str(GIT_EUSER, "GTCredentialProvider failed to provide credentials.");
return GIT_ERROR;
return GIT_EAUTH;
}

*git_cred = cred.git_cred;
Expand Down
2 changes: 1 addition & 1 deletion ObjectiveGit/GTDiffPatch.m
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ - (NSUInteger)sizeWithContext:(BOOL)includeContext hunkHeaders:(BOOL)includeHunk
}

- (NSData *)patchData {
git_buf buf = GIT_BUF_INIT_CONST(0, NULL);
git_buf buf = GIT_BUF_INIT;
git_patch_to_buf(&buf, self.git_patch);

NSData *buffer = [[NSData alloc] initWithBytes:buf.ptr length:buf.size];
Expand Down
6 changes: 3 additions & 3 deletions ObjectiveGit/GTFilterList.m
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ - (NSData *)applyToData:(NSData *)inputData error:(NSError **)error {
NSParameterAssert(inputData != nil);

git_buf input = inputData.git_buf;
git_buf output = GIT_BUF_INIT_CONST(0, NULL);
git_buf output = GIT_BUF_INIT;
int gitError = git_filter_list_apply_to_data(&output, self.git_filter_list, &input);

if (gitError != GIT_OK) {
Expand All @@ -69,7 +69,7 @@ - (NSData *)applyToPath:(NSString *)relativePath inRepository:(GTRepository *)re
NSParameterAssert(relativePath != nil);
NSParameterAssert(repository != nil);

git_buf output = GIT_BUF_INIT_CONST(0, NULL);
git_buf output = GIT_BUF_INIT;
// fixme: This is a workaround for an issue where `git_filter_list_apply_to_file`
// will not resolve relative paths against the worktree. It should be reverted when
// libgit2 has been updated to resolve that.
Expand All @@ -87,7 +87,7 @@ - (NSData *)applyToPath:(NSString *)relativePath inRepository:(GTRepository *)re
- (NSData *)applyToBlob:(GTBlob *)blob error:(NSError **)error {
NSParameterAssert(blob != nil);

git_buf output = GIT_BUF_INIT_CONST(0, NULL);
git_buf output = GIT_BUF_INIT;
int gitError = git_filter_list_apply_to_blob(&output, self.git_filter_list, blob.git_blob);

if (gitError != GIT_OK) {
Expand Down
5 changes: 3 additions & 2 deletions ObjectiveGit/GTNote.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
//

#import <Foundation/Foundation.h>
#import "git2/oid.h"
#import "git2/types.h"
#import "git2/notes.h"
#import "git2/repository.h"

@class GTSignature;
@class GTRepository;
Expand Down Expand Up @@ -88,4 +90,3 @@ NS_ASSUME_NONNULL_BEGIN
@end

NS_ASSUME_NONNULL_END

6 changes: 3 additions & 3 deletions ObjectiveGit/GTOID.m
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ - (const git_oid *)git_oid {
- (NSString *)SHA {
char *SHA = git_oid_tostr_s(self.git_oid);
NSString *str = [[NSString alloc] initWithBytes:SHA
length:GIT_OID_HEXSZ
length:GIT_OID_SHA1_HEXSIZE
encoding:NSUTF8StringEncoding];
NSAssert(str != nil, @"Failed to create SHA string");
return str;
Expand Down Expand Up @@ -98,7 +98,7 @@ + (instancetype)oidWithSHACString:(const char *)SHA {
}

- (BOOL)isZero {
return git_oid_iszero(self.git_oid) != 0;
return git_oid_is_zero(self.git_oid) != 0;
}

#pragma mark NSObject
Expand All @@ -109,7 +109,7 @@ - (NSString *)description {

- (NSUInteger)hash {
// Hash the raw OID.
NSData *data = [[NSData alloc] initWithBytesNoCopy:_git_oid.id length:GIT_OID_RAWSZ freeWhenDone:NO];
NSData *data = [[NSData alloc] initWithBytesNoCopy:_git_oid.id length:GIT_OID_SHA1_SIZE freeWhenDone:NO];
return data.hash;
}

Expand Down
1 change: 1 addition & 0 deletions ObjectiveGit/GTRepository+Blame.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#import <Foundation/Foundation.h>
#import "GTRepository.h"

#import "git2/types.h"
#import "git2/blame.h"

@class GTBlame;
Expand Down
3 changes: 2 additions & 1 deletion ObjectiveGit/GTRepository.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
#import "git2/checkout.h"
#import "git2/repository.h"
#import "git2/transport.h"
#import "git2/deprecated.h"
#import "git2/sys/transport.h"

@class GTBlob;
Expand All @@ -58,7 +59,7 @@ NS_ASSUME_NONNULL_BEGIN

/// Transport flags sent as options to +cloneFromURL... method
typedef NS_OPTIONS(NSInteger, GTTransportFlags) {
GTTransportFlagsNone = GIT_TRANSPORTFLAGS_NONE
GTTransportFlagsNone = 0
};

/// An `NSNumber` wrapped `GTTransportFlags`, documented above.
Expand Down
5 changes: 3 additions & 2 deletions script/update_libgit2
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ PATH="$ARCH_PREFIX/bin:$PATH"

cmake --version
cmake -DBUILD_SHARED_LIBS:BOOL=OFF \
-DBUILD_CLAR:BOOL=OFF \
-DTHREADSAFE:BOOL=ON \
-DBUILD_TESTS:BOOL=OFF \
-DBUILD_CLI:BOOL=OFF \
-DUSE_SSH=libssh2 \
-DCMAKE_POLICY_VERSION_MINIMUM=3.5 \
..
cmake --build .
Expand Down
Loading