Fix Crush workflow model forwarding for non-interactive runs#45471
Conversation
🤖 PR Triage
Rationale: WIP fix for smoke crush engine failure — 0 files changed yet, agent still working. Defer until in a reviewable state.
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
/smoke-crush |
|
|
|
@copilot review crush docs and fix config for custom api base url See https://github.com/github/gh-aw/actions/runs/29335131599/job/87092597521#step:28:1 |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Hey
|
|
/smoke-crush |
|
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in deb69aa. I updated the Crush engine config to write provider |
|
/smoke-crush |
|
|
|
@copilot review https://github.com/github/gh-aw/actions/runs/29338495207/job/87104032973 fix model, fix skills configuration |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in 2ae2c00. The Smoke Crush workflow now uses the Crush-supported |
|
/smoke-crush |
|
|
Smoke Crush was failing even with an explicit workflow model because the Crush engine definition exported
CRUSH_MODELbut never passed it tocrush run. That left Crush to resolve its own default large/small models, which in CI fell through to unintended provider auth paths and failed during startup.Root cause
Engine definition
model-flag: --modelto the Crush engine behavior definition.Generated command behavior
Regression coverage
--model "$CRUSH_MODEL"