Skip to content

Fix Crush workflow model forwarding for non-interactive runs#45471

Closed
pelikhan with Copilot wants to merge 6 commits into
mainfrom
copilot/aw-fix-smoke-crush-failure
Closed

Fix Crush workflow model forwarding for non-interactive runs#45471
pelikhan with Copilot wants to merge 6 commits into
mainfrom
copilot/aw-fix-smoke-crush-failure

Conversation

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Smoke Crush was failing even with an explicit workflow model because the Crush engine definition exported CRUSH_MODEL but never passed it to crush run. That left Crush to resolve its own default large/small models, which in CI fell through to unintended provider auth paths and failed during startup.

  • Root cause

    • The declarative Crush engine config set model state in env only:
      model-env-var: CRUSH_MODEL
    • But the generated command did not include a model flag, so the configured workflow model was not actually selected by the CLI.
  • Engine definition

    • Add model-flag: --model to the Crush engine behavior definition.
    • This makes gh-aw render the configured workflow model into the generated execution command instead of relying on Crush-side defaults.
  • Generated command behavior

    • With a configured model, execution now renders the equivalent of:
      crush run --verbose --model "$CRUSH_MODEL" "$(cat /tmp/gh-aw/aw-prompts/prompt.txt)"
    • Without a configured model, no model flag is emitted, preserving existing default behavior for unconfigured workflows.
  • Regression coverage

    • Extend Crush engine tests to assert:
      • the configured model is forwarded as --model "$CRUSH_MODEL"
      • the model flag is omitted when no model is configured

@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage

Field Value
Category bug
Risk medium
Score 40/100 (impact:20 urgency:10 quality:10)
Action ⏸ defer

Rationale: WIP fix for smoke crush engine failure — 0 files changed yet, agent still working. Defer until in a reviewable state.

Generated by 🔧 PR Triage Agent · 208.1 AIC · ⌖ 4.98 AIC · ⊞ 5.6K ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix smoke crush engine failure issue Fix Crush workflow model forwarding for non-interactive runs Jul 14, 2026
Copilot AI requested a review from pelikhan July 14, 2026 13:02
@pelikhan

Copy link
Copy Markdown
Collaborator

/smoke-crush

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ Smoke Crush failed. Crush encountered unexpected challenges...

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot review crush docs and fix config for custom api base url

See https://github.com/github/gh-aw/actions/runs/29335131599/job/87092597521#step:28:1

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Hey @copilot-swe-agent 👋 — great work on this bug fix! The root cause analysis is thorough and the solution is clean. The PR includes regression coverage and the change is minimal and focused. This looks ready for review! 🎉

Generated by ✅ Contribution Check · 81.7 AIC · ⌖ 13 AIC · ⊞ 6.2K ·

@pelikhan

Copy link
Copy Markdown
Collaborator

/smoke-crush

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ Smoke Crush failed. Crush encountered unexpected challenges...

Copilot AI and others added 2 commits July 14, 2026 13:35
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@copilot review crush docs and fix config for custom api base url

See https://github.com/github/gh-aw/actions/runs/29335131599/job/87092597521#step:28:1

Addressed in deb69aa. I updated the Crush engine config to write provider base_url entries into .crush.json, forward the configured workflow model to both --model and --small-model for non-interactive runs, and recompiled smoke-crush.lock.yml.

@pelikhan

Copy link
Copy Markdown
Collaborator

/smoke-crush

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ Smoke Crush failed. Crush encountered unexpected challenges...

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot review https://github.com/github/gh-aw/actions/runs/29338495207/job/87104032973

fix model, fix skills configuration

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@copilot review https://github.com/github/gh-aw/actions/runs/29338495207/job/87104032973

fix model, fix skills configuration

Addressed in 2ae2c00. The Smoke Crush workflow now uses the Crush-supported copilot/claude-sonnet-4.6 model, inline Crush skills are written to .crush/skills, and smoke-crush.lock.yml was recompiled.

@pelikhan

Copy link
Copy Markdown
Collaborator

/smoke-crush

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ Smoke Crush failed. Crush encountered unexpected challenges...

@pelikhan

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Smoke Crush failed

3 participants