C#: Use ProcessStartInfo built-in for correct escaping/quoting in the Dependency manager. - #22377
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
michaelnebel
force-pushed
the
csharp/dotnetquoting
branch
from
August 20, 2026 10:02
7cf9eb5 to
3067101
Compare
michaelnebel
force-pushed
the
csharp/dotnetquoting
branch
2 times, most recently
from
August 21, 2026 09:20
11e1ed7 to
882812b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates dependency-manager process invocation from manually quoted strings to structured argument lists for reliable escaping.
Changes:
- Refactors .NET and NuGet invocations to use argument lists.
- Updates feed-source and restore APIs accordingly.
- Adapts tests and source-generator execution.
Show a summary per file
| File | Description |
|---|---|
Runtime.cs |
Updates the IDotNet test stub. |
DotNet.cs (tests) |
Adapts command-construction tests. |
DotnetSourceGeneratorWrapper.cs |
Passes compiler arguments separately. |
PackagesConfigRestorer.cs |
Uses structured NuGet arguments. |
NugetPackageRestorer.cs |
Propagates source argument lists. |
IDotNetCliInvoker.cs |
Changes invoker methods to list arguments. |
IDotNet.cs |
Updates public command and restore contracts. |
FeedManager.cs |
Produces structured source arguments. |
DotNetCliInvoker.cs |
Starts processes with argument lists. |
DotNet.cs (dependency fetching) |
Constructs all CLI commands as argument lists. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 10/10 changed files
- Comments generated: 2
- Review effort level: Balanced
michaelnebel
force-pushed
the
csharp/dotnetquoting
branch
2 times, most recently
from
August 24, 2026 12:19
edeaaa0 to
9fd3396
Compare
michaelnebel
marked this pull request as ready for review
August 25, 2026 07:35
michaelnebel
added
the
no-change-note-required
michaelnebel
force-pushed
the
csharp/dotnetquoting
branch
from
August 25, 2026 12:49
9fd3396 to
80994d5
Compare
…ically handled escaping and quoting.
michaelnebel
force-pushed
the
csharp/dotnetquoting
branch
from
August 26, 2026 12:00
80994d5 to
08f0b16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of escaping/quoting of arguments when we invoke
dotnetin the dependency manager, we should rely on the built-in support inProcessStartInfo. That is, we should supply the arguments to the call viaArgumentListinstead ofArguments(documentation can be seen here).DCA looks good.
Also ran QA (note - this is only internally visible for GitHub), which showed significant extraction regressions for some repos (among others the
dotnet/project-system). However, Iattempted to do the extraction locally and didn't observe a similar regression. Will run QA again just to make sure.vsvim/vsvim,dotnet/project-system,microsoft/nodejstoolsandmicrosoft/ptvssucceeded in both variants and the execution times are similar (these were the outliers in the first QA run).