Skip to content

Onboard workflows to Actions lockfile - #11

Merged
nodeselector merged 1 commit into
mainfrom
oss-prep-onboard-lockfile
Jul 8, 2026
Merged

Onboard workflows to Actions lockfile#11
nodeselector merged 1 commit into
mainfrom
oss-prep-onboard-lockfile

Conversation

@nodeselector

@nodeselector nodeselector commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Part of OSS-readiness prep for the public release — see github/open-source-releases#710.

Replaces #9 (manual SHA-pinning). Instead of hand-pinning, we dogfood the lockfile.

Prep for the public open-source release (github/open-source-releases#710).

Dogfood the lockfile this repo defines: run `gh actions-lock` to pin every
resolvable action to an immutable commit SHA recorded in
.github/workflows/actions.lock. The tool narrows the mutable refs in the
workflow files to full semver (actions/checkout@v4 -> @v4.3.1,
actions/setup-go@v5 -> @v5.6.0) and records the resolved SHA + owner/repo
ids in the lockfile.

All changes here are tool-generated; nothing was hand-edited. This replaces
the manual SHA-pinning PR (#9).
Copilot AI review requested due to automatic review settings July 8, 2026 14:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

CI does not currently verify that .github/workflows/actions.lock matches the workflow refs, which undermines the PR’s stated “machine-verifiable” lockfile workflow.

Pull request overview

This PR onboards the repository’s GitHub Actions workflows to the Actions dependency lockfile format the repo defines, replacing manual SHA pinning with a generated .github/workflows/actions.lock plus semver-tagged uses: entries in workflows.

Changes:

  • Adds .github/workflows/actions.lock (schema v0.0.2) pinning workflow action refs to immutable commits.
  • Updates CI and Release workflows to use full semver tags for actions/checkout and actions/setup-go.
  • Adds a “managed by gh actions-lock” header to the workflows.
File summaries
File Description
.github/workflows/ci.yml Pins action refs to full semver tags and marks the workflow as tool-managed.
.github/workflows/release.yml Pins action refs to full semver tags and marks the workflow as tool-managed.
.github/workflows/actions.lock Introduces generated lockfile capturing resolved commit SHAs for workflow action refs.

Review details

  • Files reviewed: 2/3 changed files
  • Comments generated: 1
  • Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines 21 to +24
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v4.3.1

- uses: actions/setup-go@v5
- uses: actions/setup-go@v5.6.0
@nodeselector
nodeselector merged commit 908143b into main Jul 8, 2026
9 checks passed
nodeselector added a commit that referenced this pull request Jul 8, 2026
Prep for the public open-source release (github/open-source-releases#710).

Dogfood the lockfile this repo defines: run `gh actions-lock` to pin every
resolvable action to an immutable commit SHA recorded in
.github/workflows/actions.lock. The tool narrows the mutable refs in the
workflow files to full semver (actions/checkout@v4 -> @v4.3.1,
actions/setup-go@v5 -> @v5.6.0) and records the resolved SHA + owner/repo
ids in the lockfile.

All changes here are tool-generated; nothing was hand-edited. This replaces
the manual SHA-pinning PR (#9).
@nodeselector
nodeselector deleted the oss-prep-onboard-lockfile branch July 8, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants