fix(storage): add SSM adapter diagnostics - #5385
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
marked this pull request as draft
September 7, 2026 13:39
edersonbrilhante
added
javascript
edersonbrilhante
marked this pull request as ready for review
September 7, 2026 13:54
guicaulada
reviewed
Sep 8, 2026
guicaulada
left a comment
guicaulada
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Minor comment about the credentials cache from #5359
edersonbrilhante
force-pushed
the
ssm-storage-adapter-diagnostics
branch
from
September 8, 2026 14:29
9eda60e to
3bebc2d
Compare
edersonbrilhante
force-pushed
the
ssm-storage-adapter-diagnostics
branch
from
September 8, 2026 17:29
3bebc2d to
15ff745
Compare
guicaulada
previously approved these changes
Sep 8, 2026
edersonbrilhante
force-pushed
the
ssm-storage-adapter-diagnostics
branch
from
September 8, 2026 19:42
15ff745 to
5824918
Compare
edersonbrilhante
force-pushed
the
ssm-storage-adapter-diagnostics
branch
from
September 8, 2026 19:46
5824918 to
fa61592
Compare
edersonbrilhante
force-pushed
the
ssm-storage-adapter-diagnostics
branch
from
September 8, 2026 19:48
fa61592 to
77402d6
Compare
edersonbrilhante
force-pushed
the
ssm-storage-adapter-diagnostics
branch
from
September 8, 2026 19:54
77402d6 to
6697108
Compare
edersonbrilhante
force-pushed
the
ssm-storage-adapter-diagnostics
branch
from
September 8, 2026 19:56
6697108 to
72580d1
Compare
guicaulada
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds structured diagnostics at the asynchronous AWS SSM storage adapter boundaries. A shared logger factory attaches the canonical
aws_ssmprovider identity while each adapter keeps its own module name.Runner-config read and delete failures now preserve their original causes, retryable polling misses remain debug-level events, and terminal failures include bounded error-name chains. Credential values, private keys, Base64 contents, and stored runner configuration values are intentionally excluded from logs. Direct SSM consumer tests now pass only the SSM-specific configuration instead of the generic provider-selection field.
This PR is stacked on #5359.
Test Plan
lambdas/libs/storage-providers.git diff --checkand a focused sensitive-log-field scan.Related Issues