refactor(storage): extract runner group cache store - #5355
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
force-pushed
the
runner-group-cache-storage
branch
4 times, most recently
from
September 4, 2026 11:46
2e1cbeb to
5205369
Compare
edersonbrilhante
added
compute-provider:aws_microvm
javascript
edersonbrilhante
marked this pull request as ready for review
September 7, 2026 13:53
guicaulada
previously approved these changes
Sep 8, 2026
Base automatically changed from
refactor-runner-config-storage-provider
to
main
September 8, 2026 14:29
edersonbrilhante
force-pushed
the
runner-group-cache-storage
branch
from
September 8, 2026 14:29
dbdc14c to
fc0d3f6
Compare
edersonbrilhante
force-pushed
the
runner-group-cache-storage
branch
from
September 8, 2026 17:29
fc0d3f6 to
13a4a21
Compare
guicaulada
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracts runner-group cache access into the provider-neutral
RunnerGroupCacheStorecapability and adds the AWS SSM adapter. The control plane now asks the store to read or create the cached runner-group ID instead of importing SSM directly; SSM-specific parameter paths, tags, and AWS calls remain inside the adapter.The adapter returns
undefinedonly when the cache parameter is missing, propagates other AWS failures, preserves cache creation behavior and metadata, and rejects malformed cached IDs before they are used. Focused tests cover the not-found, AWS-error, invalid-ID, and tag paths.Test Plan
git diff --checkpassed.Related Issues