fix(multi-runner): route v1 and v2 runners separately - #5346
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 3, 2026 20:02
797e0a6 to
52aefba
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 3, 2026 20:05
819ba57 to
9777da9
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 3, 2026 20:20
9777da9 to
00c76ce
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 3, 2026 21:19
00c76ce to
01c4a78
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 3, 2026 21:40
01c4a78 to
5b2fbf4
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 3, 2026 21:52
5b2fbf4 to
afc760b
Compare
This was referenced Sep 4, 2026
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 4, 2026 17:59
afc760b to
e17ae16
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 7, 2026 15:00
e17ae16 to
861e3ca
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 8, 2026 11:11
861e3ca to
26219c7
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 8, 2026 13:41
26219c7 to
0d2262e
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 8, 2026 14:50
0d2262e to
5759b13
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 8, 2026 15:16
5759b13 to
4dabda4
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 8, 2026 17:56
40bc1e6 to
7a0371f
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 8, 2026 19:34
7a0371f to
b0d438b
Compare
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
3 times, most recently
from
September 10, 2026 11:34
4f377f3 to
6869b66
Compare
Brend-Smits
previously approved these changes
Sep 10, 2026
edersonbrilhante
force-pushed
the
fix-multi-runner-v2-routing
branch
from
September 10, 2026 16:08
47625db to
93b1c40
Compare
Brend-Smits
self-requested a review
September 10, 2026 16:11
Brend-Smits
approved these changes
Sep 10, 2026
edersonbrilhante
added a commit
that referenced
this pull request
Sep 10, 2026
## Description - Make legacy v1 inputs optional when the experimental v2 configuration is selected. - Keep validation for incomplete v1 configurations while allowing v2-only calls to omit legacy GitHub App, network, and v1 lane arguments. - Centralize v1/v2 shape validation and add regression coverage proving v2 resolves without legacy inputs. - Update Terraform version and generated documentation for the resulting contract. ## Test Plan - `terraform validate` in `modules/multi-runner` - Configuration-resolution tests for v2-only inputs - Terraform formatting, TFLint, and merge-conflict checks ## Related Issues Depends on #5346. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
edersonbrilhante
added a commit
that referenced
this pull request
Sep 10, 2026
## Description Adds the `examples/multi-runner-v2` example for the unified experimental v2 interface. - Demonstrates global defaults and per-lane runner, webhook, and compute-provider settings. - Uses the v2 module inputs without the legacy v1 compatibility arguments. - Adds example documentation, Terraform verification, provider locks, and navigation entries. ## Test Plan - `terraform init -backend=false -input=false` for `examples/multi-runner-v2` - `terraform validate` for the example - Terraform formatting, validation/TFLint, and merge-conflict checks ## Related Issues Depends on #5368, which depends on #5346. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
runner-configmodule.runners_map_v2.Test Plan
terraform fmtandgit diff --checkmodules/multi-runnerRelated Issues
Depends on #5345.