Skip to content

feat(orchestration-providers): add webhook provider modules - #5344

Merged
edersonbrilhante merged 3 commits into
mainfrom
refactor-orchestration-provider-modules
Sep 8, 2026
Merged

feat(orchestration-providers): add webhook provider modules#5344
edersonbrilhante merged 3 commits into
mainfrom
refactor-orchestration-provider-modules

Conversation

@edersonbrilhante

@edersonbrilhante edersonbrilhante commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Adds the internal webhook orchestration-provider module, including scale-up, scale-down, pool reconciliation, job retry, IAM policies, logging, validation, and provider outputs.

The module consumes the selected compute provider’s contract and keeps provider-specific orchestration resources separate from shared runner configuration and provider selection.

Test Plan

  • Repository Terraform formatting, validation/TFLint, and merge-conflict checks
  • Webhook, scale-runner, pool, and job-retry Terraform tests are included in the PR
  • Local provider-plugin handshake prevented a complete test run on macOS arm64

Related Issues

Depends on #5343.

@edersonbrilhante
edersonbrilhante requested a review from a team as a code owner September 3, 2026 19:06
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch 2 times, most recently from 6181a5c to ced68ef Compare September 3, 2026 20:03
@edersonbrilhante
edersonbrilhante requested a review from a team as a code owner September 3, 2026 20:14
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from b965de7 to be1ee32 Compare September 3, 2026 20:16
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from be1ee32 to 0dc70b7 Compare September 3, 2026 21:19
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 0dc70b7 to 19f105a Compare September 3, 2026 21:39
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 19f105a to 1426f46 Compare September 3, 2026 21:52
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 1426f46 to 2cdf04e Compare September 4, 2026 17:59
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 2cdf04e to 5a40207 Compare September 7, 2026 15:00
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch 2 times, most recently from c4baaef to b37ca14 Compare September 8, 2026 13:40
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from b37ca14 to 0a0115f Compare September 8, 2026 14:50
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 0a0115f to 8683409 Compare September 8, 2026 15:16
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 8683409 to 5f87b81 Compare September 8, 2026 15:41
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 5f87b81 to e789930 Compare September 8, 2026 16:07
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from e789930 to cbd23e1 Compare September 8, 2026 16:11
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from cbd23e1 to 7b91976 Compare September 8, 2026 16:20
Base automatically changed from refactor-compute-provider-modules to main September 8, 2026 17:44
@edersonbrilhante
edersonbrilhante force-pushed the refactor-orchestration-provider-modules branch from 7b91976 to b5fbc44 Compare September 8, 2026 17:44

@Brend-Smits Brend-Smits left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the webhook orchestration-provider split. Verified the scale-up lambda env-var contract is preserved exactly, v1's 41 keys equal the union of the 30 kept here and the 11 supplied by the EC2 provider contract (0 dropped / 0 added).

One cross-stack note: scale-up/scale-down here still use the colon-joined PARAMETER_GITHUB_APP_* list transport (#5282), which the in-flight manifest PR replaces; whichever lands second will need to reconcile, and the v2 duplication means that fix has to be applied here too.

@edersonbrilhante
edersonbrilhante merged commit c05c9b3 into main Sep 8, 2026
58 of 59 checks passed
@edersonbrilhante
edersonbrilhante deleted the refactor-orchestration-provider-modules branch September 8, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants