CodeIssuesTask action - #214
Merged
Merged
Conversation
Provisionally reducing the severity of JavaFrame error, removing dependency on findjobj should become a new issue
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
======================================
Coverage 0.86% 0.86%
======================================
Files 625 625
Lines 27004 27004
======================================
Hits 233 233
Misses 26771 26771
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Kevin-Mattheus-Moerman
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a "build" step to the CI workflow, that runs the Code Analyser (
CodeIssuesTask) and fails on errors. It should help keeping track of features of MATLAB that change over time. E.g. there's a couple of issues that used to be warnings, but became errors after R2025a:docs/DEMO_febio_0059_face_mask_loading.mused1:size(Vr1)where Vr1 is a 2D array, which now requires an explicit1:size(Vr1,1)JavaFramehas been dropped. I created a new issue for this (Drop dependency on findjobj #213), for now I hard-set the severity of the error back to "warning" and added an additional check that should warn for future uses offindjobj.