Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,16 @@ public class SandboxBreakdown {
@JsonProperty("result")
private final String result;

@JsonProperty("process")
private final String process;

@JsonProperty("details")
private final List<SandboxDetail> details;

private SandboxBreakdown(String subCheck, String result, List<SandboxDetail> details) {
private SandboxBreakdown(String subCheck, String result, String process, List<SandboxDetail> details) {
this.subCheck = subCheck;
this.result = result;
this.process = process;
this.details = details;
}

Expand All @@ -36,6 +40,10 @@ public String getResult() {
return result;
}

public String getProcess() {
return process;
}

public List<SandboxDetail> getDetails() {
return details;
}
Expand All @@ -47,6 +55,7 @@ public static class Builder {

private String subCheck;
private String result;
private String process;
private List<SandboxDetail> details = new ArrayList<>();

private Builder() {
Expand All @@ -62,6 +71,11 @@ public Builder withResult(String result) {
return this;
}

public Builder withProcess(String process) {
this.process = process;
return this;
}

public Builder withDetail(String name, String value) {
SandboxDetail detail = new SandboxDetail(name, value);
details.add(detail);
Expand All @@ -72,7 +86,7 @@ public SandboxBreakdown build() {
notNullOrEmpty(subCheck, "subCheck");
notNullOrEmpty(result, "result");

return new SandboxBreakdown(subCheck, result, details);
return new SandboxBreakdown(subCheck, result, process, details);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.nullValue;
import static org.junit.Assert.fail;

import com.yoti.api.client.sandbox.docs.request.check.report.SandboxBreakdown;
Expand All @@ -13,7 +14,8 @@
public class SandboxBreakdownTest {

private static final String SOME_SUB_CHECK = "someSubCheck";
private static final String SOME_RESULT = "someResult";
private static final String SOME_RESULT = "someResult";
private static final String SOME_PROCESS = "someProcess";
private static final String SOME_DETAIL_NAME = "someDetailName";
private static final String SOME_DETAIL_VALUE = "someDetailValue";

Expand Down Expand Up @@ -50,9 +52,21 @@ public void builder_shouldBuildCorrectlyWithRequiredProperties() {

assertThat(result.getSubCheck(), is(SOME_SUB_CHECK));
assertThat(result.getResult(), is(SOME_RESULT));
assertThat(result.getProcess(), is(nullValue()));
assertThat(result.getDetails(), hasSize(0));
}

@Test
public void builder_shouldBuildCorrectlyWithProcess() {
SandboxBreakdown result = SandboxBreakdown.builder()
.withSubCheck(SOME_SUB_CHECK)
.withResult(SOME_RESULT)
.withProcess(SOME_PROCESS)
.build();

assertThat(result.getProcess(), is(SOME_PROCESS));
}

@Test
public void builder_shouldCreateSandboxDetailsForSuppliedKeyValue() {
SandboxBreakdown result = SandboxBreakdown.builder()
Expand Down
Loading