fix(cli): preserve case-distinct paths-file entries - #1431
Merged
Conversation
Greptile SummaryThe PR corrects
Confidence Score: 5/5The PR appears safe to merge; the updated deduplication preserves case-distinct files while avoiding duplicate collection of filesystem aliases. No actionable new issue remains. The previous duplicate-file finding was manually resolved without explanation, and the current canonical-path deduplication also addresses its underlying case-alias behavior.
|
| Filename | Overview |
|---|---|
| src/scan_result_shaping/selection.rs | Uses canonical filesystem identity for frontier deduplication while preserving independent selection and missing-entry sets. |
| src/scan_result_shaping/selection_test.rs | Verifies case-distinct collection, normalized-repeat deduplication, alias handling, and downstream selection filtering across filesystem semantics. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Normalized paths-file entry] --> B{Entry exists?}
B -->|Yes| C[Canonicalize filesystem path]
C --> D[Deduplicate collection frontier by file identity]
B -->|Yes| E[Build case-insensitive selection key]
E --> F[Deduplicate selection filters]
B -->|No| G[Deduplicate missing normalized entries]
Reviews (2): Last reviewed commit: "fix(cli): preserve case-distinct paths-f..." | Re-trigger Greptile
Signed-off-by: Maxim Stykow <maxim.stykow@gmail.com>
mstykow
force-pushed
the
fix/paths-file-case-distinct
branch
from
September 9, 2026 08:12
f41476d to
f9d6a44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--paths-fileentry when deduplicating the direct collection frontier.Issues
--paths-filesilently drops files whose paths differ only in capitalization #1430Scope and exclusions
--paths-fileresolution, frontier construction, and regression coverage through collection and selection filtering.--include/--excludeglob semantics and ordinary directory discovery are unchanged.How to verify
Example.jsandexample.js; confirm both file entries appear with their respective license detections. Add./Example.jsto the paths file and confirm the normalized repeat does not add a third entry.Expected-output fixture changes
🤖 Generated with Claude Code