feat(export): 【openscreen】4K品質ボタンを追加する - #577
Draft
nanameru wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
MP4エクスポート画面へ4K品質ボタンを追加し、16:9なら3840×2160、9:16なら2160×3840で書き出せるようにします。
Closes nanameru#6
変更内容
ExportQualityへ4kを追加--quality 4kを追加UI判断
既存の品質選択グリッドへ同一スタイルのボタンを1つ追加するsmall-changeであり、主要導線・情報構造・ブランド・共通コンポーネントを変更しないためFigma工程を省略しました。
検証
npx tsc -p tsconfig.test.json --noEmit: passednpm run lint: passed(既存warning 15件)npm run build-vite: passedtest-board impact: TC-007〜TC-011を検出--quality 4k出力し、ffprobeでH.264 / 3840×2160 / 60fps / 2.083秒を確認リスク
低解像度素材ではアップスケールとなり、細部は増えません。4Kは1080pより処理時間・ファイル容量・GPU負荷が増えます。ビットレートはネイティブエンコーダーが自動決定し、既定値は1080pのままです。