fix(mac): 【openscreen】録画終了時の保存失敗を救済する - #571
Draft
nanameru wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
macOS native capture helper が完成済みMP4を書き出した後、
stopped通知前後で終了した場合に、録画を保存失敗として取り残さないようにします。Closes nanameru#4
変更内容
mp4boxでMP4をstreaming解析し、実映像track・sample tableを持つ出力だけを救済recoveredを追加test-board.yamlを追加検証
npm test: 188 files passed / 2246 tests passed / 2 skippednpx tsc --noEmit: passnpx tsc -p tsconfig.test.json --noEmit: passnpm run lint: pass(既存warning 15件)npm run build-vite: pass.openscreenprojectの保存を確認リスク
mp4boxは1MiB単位で読み、mdatを保持しないため、大容量録画を一括でメモリへ載せません。補足
作業Issueはfork側です: nanameru#4