Skip to content

fix(editor): zoom/pan the whole timeline pane on scroll, not just the lanes (cherry-pick for 1.10.0-rc.2) - #477

Merged
EtienneLescot merged 2 commits into
release/v1.10.0from
claude/timeline-mouse-scroll-rc2-cherrypick
Aug 22, 2026
Merged

fix(editor): zoom/pan the whole timeline pane on scroll, not just the lanes (cherry-pick for 1.10.0-rc.2)#477
EtienneLescot merged 2 commits into
release/v1.10.0from
claude/timeline-mouse-scroll-rc2-cherrypick

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Cherry-pick of #467 onto release/v1.10.0 for the 1.10.0-rc.2 cut.

Summary

  • The wheel listener for Ctrl+Scroll zoom / Shift+Scroll pan lived on .tlTracks alone, so scrolling over the ruler, the hint labels, or the nav/minimap bar silently did nothing — only the lanes responded.
  • Moved the listener to the whole timeline pane (the root .tl container) while keeping the geometry math anchored to the tracks element.
  • Regression tests cover both the Ctrl+wheel zoom and Shift+wheel pan paths from the ruler.

Test plan

  • Cherry-picked cleanly onto release/v1.10.0, no conflicts
  • npx vitest --run on the two affected test files — 16 passed
  • npx biome check on changed files — clean
  • npx tsc --noEmit — clean
  • Already reviewed and merged to main as fix(editor): zoom/pan the whole timeline pane on scroll #467 (CodeRabbit: no actionable comments)

🤖 Generated with Claude Code

… lanes

The wheel listener lived on .tlTracks alone, so Ctrl/Shift+scrolling over
the ruler, the hint labels, or the nav bar did nothing — only scrolling
over the lanes zoomed or panned.
CodeRabbit flagged that the panel-wide wheel fix only had regression
coverage for Ctrl+wheel zoom from the ruler, not Shift+wheel pan.
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b371434f-f6b8-471f-b4a8-192f382fbee2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot
EtienneLescot merged commit e31c1ed into release/v1.10.0 Aug 22, 2026
17 checks passed
@EtienneLescot
EtienneLescot deleted the claude/timeline-mouse-scroll-rc2-cherrypick branch August 22, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant