fix(editor): close the clip picker on an outside click (1.10.0.rc2 cherry-pick) - #476
Merged
EtienneLescot merged 1 commit intoAug 22, 2026
Conversation
It previously only closed by picking a clip or re-clicking the trigger, matching the mousedown-outside pattern EditorTopBar's LangButton already uses. Covers it with an e2e test.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release/v1.10.0for 1.10.0.rc2.LangButtonalready uses inEditorTopBar.tsx. Previously it only closed by selecting a clip or re-clicking the trigger.Related issue
No linked issue — follow-up cherry-pick of #464.
Type of change
Release impact
Desktop impact
Screenshots / video
UI-only popover behavior change; no visual/styling change. See #464 for the original verification.
Testing
release/v1.10.0, no conflicts.npx biome checkon both changed files — clean.v4-shell.spec.tse2e suite (5/5, including the new outside-click test).🤖 Generated with Claude Code