fix(timeline): remove the dead Add Full Camera toolbar button - #466
Merged
Conversation
The button always looked clickable but silently no-opped on any project without a webcam clip. Add Full Camera stays reachable via the C shortcut and the AI agent tool, both of which already gate on hasAnyClipWithCamera (#353) and are unaffected by this change.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (16)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe camera timeline now uses shared no-webcam messaging and removes the redundant fullscreen camera toolbar entry. Related availability tests and locale translations were removed. Camera shortcut and empty-lane messaging tests remain. ChangesCamera timeline cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes a nonfunctional timeline button while preserving the existing shortcut, AI action, and camera-region editing paths; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Addressed the CodeRabbit pre-merge warnings:
No other findings from the review. |
This was referenced Aug 22, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maximize2,V4Timeline.tsx) — it always looked clickable but silently no-ops (addCameraFullscreenrefuses to write a region) on any project without a webcam clip, per the [Bug]: Add Full Camera is offered on projects with no webcam and silently renders nothing #353 gate.Cshortcut and the AI agent tool both call the same gatedaddCameraFullscreenstore action, and the timeline lane still renders/edits existing camera-fullscreen regions.buttons.addCameraFullscreenstring from all 13 locales.Related issue
No tracked issue — reported directly by screenshot (button circled in the timeline toolbar), confirmed non-functional by reading the code path.
Type of change
Release impact
Desktop impact
Screenshots / video
Not attached — this removes one existing toolbar icon (
Maximize2, "Add Full Camera") with no other visual change; see the code diff for the exact before/after.Testing
npx vitest runoversrc/components/ai-edition+src/lib/ai-edition+src/lib/shortcuts— 883 tests passnpx biome checkon all changed files — cleannpx tsc --noEmit— cleannpm run i18n:check— all 12 locales still matchenacross all namespaces🤖 Generated with Claude Code
Summary by CodeRabbit