Skip to content

nginx/csp: add tests for frame-src & frame-ancestors - #2159

Open
alxndrsn wants to merge 1 commit into
getodk:nextfrom
alxndrsn:csp-frame-tests
Open

nginx/csp: add tests for frame-src & frame-ancestors#2159
alxndrsn wants to merge 1 commit into
getodk:nextfrom
alxndrsn:csp-frame-tests

Conversation

@alxndrsn

@alxndrsn alxndrsn commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Setup for #2080

What has been done to verify that this works as intended?

  • ran locally
  • CI

Why is this the best possible solution? Were any other approaches considered?

No other approaches considered. These tests are brought in as set-up to changing frame rules (e.g. #2155, #2080).

How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?

No change - just tests.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

@@ -1,9 +1,12 @@
/* global document */

@alxndrsn alxndrsn Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint global isn't scoped to the evaluate block, and now this one is used in multiple evaluate blocks.

'disposition': 'enforce',
'blocked-uri': 'inline',
'line-number': 5,
'line-number': 4,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why this changed.

@alxndrsn
alxndrsn requested a review from matthew-white August 25, 2026 10:08
@alxndrsn
alxndrsn marked this pull request as ready for review August 25, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant