fix: atomic entity file writes to avoid corruption on process kill - #5
Open
liamburja wants to merge 1 commit into
Open
fix: atomic entity file writes to avoid corruption on process kill#5liamburja wants to merge 1 commit into
liamburja wants to merge 1 commit into
Conversation
writeEntityRows wrote directly to <entity>.json. A process killed mid-write (e.g. Cloud Run SIGTERM/SIGKILL) could leave it truncated, and if the pending commit still reached the remote before the kill, the corrupted file would be permanently baked into git history and break every future clone. Now writes go to a sibling temp file and rename() over the target, which is atomic on the same filesystem. A .gitignore for *.tmp is created on init so a leftover temp file (killed between write and rename) never gets committed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeEntityRows wrote directly to .json. A process killed mid-write (e.g. Cloud Run SIGTERM/SIGKILL) could leave it truncated, and if the pending commit still reached the remote before the kill, the corrupted file would be permanently baked into git history and break every future clone.
Now writes go to a sibling temp file and rename() over the target, which is atomic on the same filesystem. A .gitignore for *.tmp is created on init so a leftover temp file (killed between write and rename) never gets committed.