Address SonarQube concerns - #44
Merged
Merged
Conversation
|
gchqdev227
force-pushed
the
feature/address-sonarqube
branch
from
August 20, 2026 12:10
0c08a80 to
66c18e1
Compare
|
gchqdev227
marked this pull request as ready for review
August 20, 2026 14:05
ab295382
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SonarQube has picked up a lot of false positives, mainly due to the use of Docker, abstract classes (with less-than-ideal Liskov properties) and other design decisions. This MR will contain the fixes, being addressed on an ad-hoc basis.