Skip to content

test: add JavaScript optional-chaining parser fixture #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ranita872 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: add JavaScript optional-chaining parser fixture #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a64f610
test: add optional chaining parser fixture
ranita872 Sep 5, 2026
edb21d0
style: format parser fixture test
ranita872 Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/quality-judge/tests/fixtures/javascript/optional-chaining.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export function getOwnerName(record) {
return record?.owner?.profile?.name ?? "unknown";
}

export function getFirstItem(items) {
return items?.[0]?.value ?? null;
}
17 changes: 17 additions & 0 deletions packages/quality-judge/tests/parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ describe("parser-backed quality lane", () => {
it.each([
["typescript/healthy.ts", "typescript"],
["javascript/healthy.js", "javascript"],
["javascript/optional-chaining.js", "javascript"],
] as const)("parses %s with the real TypeScript compiler AST", (path, language) => {
const result = parseQualitySource(path, fixture(path));
expect(result.ok).toBe(true);
Expand All @@ -22,6 +23,22 @@ describe("parser-backed quality lane", () => {
expect(result.features.nodeCount).toBeGreaterThan(5);
expect(result.features.functionCount).toBeGreaterThan(0);
});
it("keeps optional chaining bounded and source-free in derived output", () => {
const source = fixture("javascript/optional-chaining.js");
const result = parseQualitySource("javascript/optional-chaining.js", source);

expect(result.ok).toBe(true);
if (!result.ok) return;

expect(result.features.language).toBe("javascript");
expect(result.features.parserVersion).toContain("typescript-");
expect(result.features.functionCount).toBe(2);
expect(result.features.nodeCount).toBeGreaterThan(5);
expect(result.features.nodeCount).toBeLessThan(100);
expect(JSON.stringify(result)).not.toContain(source);
expect(JSON.stringify(result)).not.toContain("getOwnerName");
expect(JSON.stringify(result)).not.toContain("getFirstItem");
});

it("leaves Python and Go unsupported instead of applying lexical quality claims", () => {
expect(parseQualitySource("main.py", "def main():\n return 1")).toEqual({
Expand Down