Improved IsValid resolver understand types that track their own validity. - #64
Merged
Conversation
…n validity Is Valid only checked for null. Several types here stay non-null after they stop referring to anything - an ActiveEffectHandle whose effect was removed, an AbilityHandle whose ability was revoked, an empty Tag - so the resolver called them valid and everything downstream acted on nothing. That is the opposite of what the resolver is for.
Contributor
There was a problem hiding this comment.
Pull request overview
Extends validity checks beyond nullability to types tracking their own usability.
Changes:
- Adds the
IValidatablecontract. - Implements it for tags and effect/ability handles.
- Updates
IsValidResolverand tests for invalidated values.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Forge/Core/IValidatable.cs |
Defines the validity contract. |
Forge/Tags/Tag.cs |
Exposes tag validity through the contract. |
Forge/Effects/ActiveEffectHandle.cs |
Exposes active-effect handle validity. |
Forge/Abilities/AbilityHandle.cs |
Exposes granted-ability handle validity. |
Forge/Abilities/AbilityInstanceHandle.cs |
Exposes ability-instance handle validity. |
Forge/Statescript/Properties/IsValidResolver.cs |
Evaluates IValidatable.IsValid. |
Forge.Tests/Statescript/Resolvers/IsValidResolverTests.cs |
Tests validity-aware resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Is Valid only checked for null. Several types here stay non-null after they stop referring to anything - an ActiveEffectHandle whose effect was removed, an AbilityHandle whose ability was revoked, an empty Tag - so the resolver called them valid and everything downstream acted on nothing. That is the opposite of what the resolver is for.