Added support for revoking permanently granted abilities. - #61
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit ability revocation and clearing APIs, Statescript integration, cooldown continuity, tests, and documentation.
Changes:
- Adds
RevokeAbility,ClearAbility, andTryRevokeAbilityNode. - Preserves cooldown reporting across revoke/re-grant cycles.
- Updates tests, documentation, and icon transparency.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
icon.svg |
Removes embedded background. |
Forge/Statescript/Nodes/Condition/TryRevokeAbilityNode.cs |
Adds revocation condition node. |
Forge/Statescript/Nodes/Condition/AbilityRevokeScope.cs |
Defines revocation scopes. |
Forge/Statescript/Nodes/Action/GrantAbilityPermanentlyNode.cs |
Updates revocation guidance. |
Forge/Statescript/Nodes/AbilityNodeUtilities.cs |
Resolves single or array handles. |
Forge/Effects/EffectsManager.cs |
Finds active effects by data. |
Forge/Core/EntityAbilities.cs |
Implements revocation and clearing. |
Forge/Abilities/Ability.cs |
Improves cooldown lookup. |
Forge.Tests/Statescript/Nodes/Condition/TryRevokeAbilityNodeTests.cs |
Tests the new node. |
Forge.Tests/Abilities/EntityAbilitiesEventsTests.cs |
Tests lifecycle events. |
Forge.Tests/Abilities/AbilitiesTests.cs |
Tests removal and cooldown behavior. |
docs/statescript/nodes/condition/try-revoke-ability-node.md |
Documents the node. |
docs/statescript/nodes/condition/README.md |
Lists the node. |
docs/statescript/nodes/action/README.md |
Updates permanent-grant description. |
docs/statescript/nodes/action/grant-ability-permanently-node.md |
Documents revocation. |
docs/statescript/nodes/action/cancel-ability-node.md |
Distinguishes cancellation from revocation. |
docs/statescript/nodes/action/cancel-abilities-node.md |
Distinguishes cancellation from revocation. |
docs/abilities.md |
Documents revocation and clearing APIs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Fixed
Changed