feat: align log to stream + output stream to console - #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build facility for logging to console.
got reminded that log can be to stream, i only was missing an IByteWriter implementation to cout. so added one.
(also removed initializing mLog for the stream case, to align with file, with lazy creation avoiding what threads issues i had back then).
now it's possible to just log to stream in tests and get it right to the console, instead of creating file and then having to go and read it. much more convenient.
if logging to console, then to check logs within test context, then where running
ctest, add-Vto show console output.