Skip to content

Fix implicit return assertions after statements #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szw9999 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix implicit return assertions after statements #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...low-runtime/src/__tests__/__fixtures__/bugs/2-implicit-function-return-after-statement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/* @flow */

export const input = `
function testFunction() : string {
const value = "hello";
}
`;

export const expected = `
import t from "flow-runtime";

function testFunction() {
const _returnType = t.return(t.string());

const value = "hello";
return _returnType.assert();
}
`;
2 changes: 1 addition & 1 deletion packages/babel-plugin-flow-runtime/src/transformVisitors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ export default function transformVisitors (context: ConversionContext): Object {
if (body.node.body
// do not add if last statement is return one
&& (body.node.body.length === 0
|| !body.node.body[ body.node.body.length - 1].type === "ReturnStatement")
|| body.node.body[body.node.body.length - 1].type !== 'ReturnStatement')
) {
// we do not add arguments here
// only "return;"
Expand Down