Skip to content

Fix type parameter references when assertions are disabled #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
selimeneserd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type parameter references when assertions are disabled #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ...el-plugin-flow-runtime/src/__tests__/__fixtures__/bugs/180-type-parameter-assert-false.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/* @flow */

export const input = `
function foo<X>() {
let bar: X;
}
`;

export const expected = `
import t from "flow-runtime";
function foo() {
const X = t.typeParameter("X");
let _barType = X,
bar;
}
`;

export const annotated = `
import t from "flow-runtime";
function foo() {
let bar;
}
t.annotate(foo, t.function(_fn => {
const X = _fn.typeParameter("X");
return [];
}));
`;

export const combined = `
import t from "flow-runtime";
function foo() {
const X = t.typeParameter("X");
let _barType = X,
bar;
}
t.annotate(foo, t.function(_fn => {
const X = _fn.typeParameter("X");
return [];
}));
`;
8 changes: 6 additions & 2 deletions packages/babel-plugin-flow-runtime/src/transformVisitors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@ export default function transformVisitors (context: ConversionContext): Object {
}
const {name} = id.node;

if (!shouldCheck) {
return;
}

if (!path.has('init') || path.parentPath.node.kind !== 'const') {
const valueUid = path.scope.generateUidIdentifier(`${name}Type`);
path.scope.setData(`valueUid:${name}`, valueUid);
Expand Down Expand Up @@ -263,7 +267,7 @@ export default function transformVisitors (context: ConversionContext): Object {
));
}

if (shouldCheck && path.has('init')) {
if (path.has('init')) {
const wrapped = context.assert(
valueUid,
path.get('init').node
Expand All @@ -276,7 +280,7 @@ export default function transformVisitors (context: ConversionContext): Object {
));
}
}
else if (shouldCheck) {
else {
const wrapped = context.assert(
convert(context, id.get('typeAnnotation')),
path.get('init').node
Expand Down