Skip to content

Fix warn mode throwing validation errors #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
selimeneserd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix warn mode throwing validation errors #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/flow-runtime/src/TypeContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,10 +1027,16 @@ export default class TypeContext {
}

warn <T, V: T | any> (type: Type<T>, input: V, prefix: string = '', path?: string[]): V {
const validation = this.validate(type, input, prefix, path);
const message = makeWarningMessage(validation);
if (typeof message === 'string') {
this.emitWarningMessage(message);
try {
const validation = this.validate(type, input, prefix, path);
const message = makeWarningMessage(validation);
if (typeof message === 'string') {
this.emitWarningMessage(message);
}
}
catch (error) {
const message = error && error.message ? error.message : String(error);
this.emitWarningMessage(`Warning: ${message}`);
}
return input;
}
Expand Down
15 changes: 14 additions & 1 deletion packages/flow-runtime/src/typed.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,19 @@ describe('Typed API', () => {

});

it('should warn instead of throwing when validation throws', () => {
const context = t.createContext();
const type = context.$shape(context.string());
let warning;
const input = {};
context.emitWarningMessage = (message) => {
warning = message;
};

equal(context.warn(type, input), input);
ok(warning.indexOf('Can only $Shape<T> object types.') !== -1);
});

it('should $Keys<A>', () => {
const A = t.object(
t.property('name', t.string()),
Expand Down Expand Up @@ -558,4 +571,4 @@ describe('Typed API', () => {
))
);
});
});
});