Re-pin the stale dependency hash; add the missing test step (672 tests had no runner) - #1
Merged
Conversation
The manifest declared golden_float-0.2.0 against an upstream that is now 2.1.0, so nothing could fetch. There was no test step: 672 test blocks across 104 files and no way to run any of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest pinned
golden_float-0.2.0-h7LKhdEX…while upstream is2.1.0, sozig buildfailed at fetch with a hash mismatch — before compiling anything. Re-pinned withzig fetch --save.Underneath that: there was no
teststep.zig build testanswerederror: no step named 'test', while 672testblocks sit across 104 files — 558 of them insrc/hslm/alone. The only step wastrain, which builds one executable. Added a test step over the five module roots the build already declares.The repository's one existing workflow,
queen-deploy.yml, never runszig build, which is why none of this had surfaced. Added a workflow that does, on Zig 0.15.2.Coverage is partial and I would rather say so than imply otherwise: the five module roots do not reach all 104 files. The count CI reports is the honest current number, not the 672 declared.