fix(ci): check out the submodule holding the design tri rtl check reads (Closes #2307)

[gHashTag]

Closes #2307.

Third sequential cause in the cli-tri build job. #2303 fixed the yosys ordering, #2305 assigned dry_run_sweep_ok. With both landed the tests report 156 passed; 0 failed and the job reached a step that had never executed once in the workflow's history:

./target/debug/tri rtl check chips/phi --json
Error: No such file or directory (os error 2)
verdict lines: 0
##[error]tri rtl check emitted 0 verdicts; five checks should each emit one

chips/phi is a gitlink (mode 160000) to gHashTag/tt-trinity-phi. The checkout was a bare uses: actions/checkout@v4 with no with: block, so submodules took its default of false and the directory was empty on the runner. The binary was never broken; it had nothing to read.

The change

       - uses: actions/checkout@v4
+        with:
+          submodules: true

Plus the comment explaining it. Nothing else in the workflow is touched — +14/-0.

Why this was mechanical, and not a secrets decision

submodules: true under the default GITHUB_TOKEN only clones a public submodule; the token is scoped to this repository alone. A private submodule would have converted a failing step into a failing checkout, and would have needed a PAT or deploy key — a secrets call, not a mechanical one. All three are public:

submodule	repo	private	size
chips/phi	gHashTag/tt-trinity-phi	false	941 KB
chips/euler	gHashTag/tt-trinity-euler	false	3,954 KB
chips/gamma	gHashTag/tt-trinity-gamma	false	5,365 KB

true pulls all three, ~10.2 MB, which does not move this job's cost. None of the three has a nested .gitmodules, so recursive would buy nothing and true is the minimal setting that works.

No other workflow in this repo checks out submodules, so there was no working configuration to copy — the setting is derived from the constraint rather than from precedent. (fpga-build.yml clones prjxray with --recursive, but that is a third-party clone in a run: block, not actions/checkout.)

Verification

Not compiled — the authoring machine had ~230 MB free, too little to check out the repo or run cargo. Verified through the GitHub contents API against the pinned gitlink f5456685c3593665153fe2765c85bb1f46ec14c2, not against main, since a checkout resolves the pin and an orphaned pin would fail the clone outright:

• the pinned commit is reachable in tt-trinity-phi (dated 2026-05-18);
• info.yaml is present (3,830 bytes) and sets top_module: "tt_um_trinity_nano", so top_from_info resolves;
• it declares 49 source_files, src/ holds 51 .v files at that commit, and all 49 resolve — parsed with a transcription of declared_sources() rather than by eye.

So check 1 sources resolve passes rather than merely emitting a FAIL line, and the other four verdicts come from a single yosys pass already on PATH from #2303. This should produce five passing verdicts, not just five lines.

Because .github/workflows/cli-tri.yml is inside this workflow's own trigger paths, build runs on this PR — so the fix is observable here rather than only after merge.

Not in scope

The N < 5 assertion is byte-identical, verified by parsing both YAMLs and comparing the final step's run block. The step asserted five verdicts and got zero; that is the guard working. build was not added to the required contexts.

One thing this does not fix, deliberately: top_from_info in cli/tri/src/rtl.rs reads info.yaml with a plain ? while its sibling declared_sources wraps the identical failure in .with_context() naming the path. That asymmetry is why a missing submodule surfaced as an unattributed os error 2 and cost a diagnosis. It is a separate change from a CI checkout fix.

[github-actions]

📓 NotebookLM Notebook linked to this PR

• Notebook ID: b83263109fb055dc
• URL: https://notebooklm.google.com/notebook/b83263109fb055dc

This notebook contains session context, decisions, and artifacts for this work.

[github-actions]

PR Dashboard

Generated at: 2026-08-20 09:37:04 UTC

• fix(ci): check out the submodule holding the design tri rtl check reads (Closes #2307) #2308 fix(ci): check out the submodule holding the design tri rtl check reads (Closes #2307) | Created: 2026-08-20 | Updated: 2026-08-20 | 13 failing / 24 total
• fix(ci): one NOW entry per file, and retire merge=union #2298 fix(ci): one NOW entry per file, and retire merge=union | Created: 2026-08-20 | Updated: 2026-08-20 | 6 failing / 34 total
• ci: eleven merge-critical gates were silent on stacked PRs #2169 ci: eleven merge-critical gates were silent on stacked PRs | Created: 2026-08-14 | Updated: 2026-08-14 | 5 failing / 30 total
• corpus: freeze the damage, patch one class at a time, and say where one rule stops #2161 corpus: freeze the damage, patch one class at a time, and say where one rule stops | Created: 2026-08-14 | Updated: 2026-08-20 | 0 failing / 9 total
• tri triage: five ordered classes, and blocked is tested before actionable (#2156) #2157 tri triage: five ordered classes, and blocked is tested before actionable (#2156) | Created: 2026-08-14 | Updated: 2026-08-14 | 0 failing / 17 total
• parser: nesting decides the separator, never the terminator (#2127) #2151 parser: nesting decides the separator, never the terminator (#2127) | Created: 2026-08-14 | Updated: 2026-08-14 | 2 failing / 26 total
• Unbreak FPGA CI and correct two unbacked hardware claims #2081 Unbreak FPGA CI and correct two unbacked hardware claims | Created: 2026-08-11 | Updated: 2026-08-20 | 5 failing / 27 total
• feat(igla): Wave Loop 898 — module-scope [615][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1900 feat(igla): Wave Loop 898 — module-scope [615][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
• chore: civilian mesh positioning — drop drone wording (bpsk.t27) #1874 chore: civilian mesh positioning — drop drone wording (bpsk.t27) | Created: 2026-08-07 | Updated: 2026-08-07 | 2 failing / 25 total
• feat(igla): Wave Loop 897 — module-scope [613][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1858 feat(igla): Wave Loop 897 — module-scope [613][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
• feat(igla): Wave Loop 896 — module-scope [611][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1856 feat(igla): Wave Loop 896 — module-scope [611][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
• feat(igla): Wave Loop 895 — module-scope [609][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1854 feat(igla): Wave Loop 895 — module-scope [609][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
• feat(igla): Wave Loop 894 — module-scope [607][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1852 feat(igla): Wave Loop 894 — module-scope [607][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
• feat(igla): Wave Loop 893 — module-scope [605][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1850 feat(igla): Wave Loop 893 — module-scope [605][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
• feat(igla): Wave Loop 892 — module-scope [603][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1847 feat(igla): Wave Loop 892 — module-scope [603][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 1 failing / 3 total
• feat(igla): Wave Loop 891 — module-scope [601][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1844 feat(igla): Wave Loop 891 — module-scope [601][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 0 failing / 4 total
• feat(igla): Wave Loop 890 — module-scope [599][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1842 feat(igla): Wave Loop 890 — module-scope [599][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-07 | Updated: 2026-08-07 | 0 failing / 4 total
• feat(igla): Wave Loop 883 — module-scope [585][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1815 feat(igla): Wave Loop 883 — module-scope [585][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 1 total
• feat(igla): Wave Loop 882 — module-scope [583][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1813 feat(igla): Wave Loop 882 — module-scope [583][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 12 total
• feat(igla): Wave Loop 881 — module-scope [581][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes #1810 feat(igla): Wave Loop 881 — module-scope [581][2]^6 Pt non-power-of-two outer-dimension array-of-struct variable from call with indexed signed writes | Created: 2026-08-06 | Updated: 2026-08-06 | 0 failing / 12 total

Summary

Status	Count
Total Open PRs	20
PRs with Failing Checks	6
PRs with All Checks Green	14
READY	7
FAILING	6
PENDING	0

Seal Status

• ⚠️ STALE -- sha256(compiler.rs)=cbbfac87dff3 != manifest seal=87e5cbd3ad94.
  The committed NMSE numbers were certified against an older compiler.rs.
  Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).