docs(now): retract "master has no branch protection" -- wrong endpoint - #2294
Merged
Conversation
The previous NOW entry asserts, in a BINDING honesty limit, that master has no branch protection, on the strength of `GET /repos/gHashTag/t27/branches/master/protection` returning `404 Branch not protected`. That endpoint reports only legacy branch protection and 404s for a repository protected by rulesets. Master IS protected, by the active ruleset t27-master-protection: PRs required, deletion and non-fast-forward blocked, and four required status contexts (check-now-freshness, validate, check, check-linked-issue). The observation behind the claim survives and is better explained. PR #2291 merged three seconds before its own corpus-ratchet run began not because nothing is required, but because corpus-ratchet is not one of the required four -- which is also why coverage and withdrawn-live sit red on master while PRs keep merging. This sharpens rather than softens the original finding: the cargo test step was added to a workflow outside the required set, so even green it could never have blocked a merge. It was wrong on its numbers and wrong in its placement, and the second error would have outlived fixing the first. Adding corpus-ratchet to the ruleset is deliberately not done here: it is currently failing on master, so requiring it would block every PR. That must follow the ratchet in #2292, not precede it. Refs #2292
gHashTag
enabled auto-merge (squash)
August 20, 2026 04:07
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2292
Retracts a false BINDING honesty limit I landed in
9fec1a9ba(PR #2293) an hour ago.The false claim
That entry states "
masterhas no branch protection", citing:/branches/{branch}/protectionreports only legacy branch protection. A repository protected by rulesets returns 404 from it while being fully protected. I read a 404 as "unprotected" when it means "not protected by that mechanism".What is actually true
Master is protected: PRs required, force-push and deletion blocked, four required contexts —
check-now-freshness,validate,check,check-linked-issue.The observation survives, better explained
PR #2291 merged at
03:57:13Zwhile its owncorpus-ratchetrun started at03:57:16Z— three seconds before the gate it was adding began to run. Not because nothing is required, but becausecorpus-ratchetis not one of the required four. Neither arecoverageorwithdrawn-live, which is precisely why all three sit red on master while PRs keep merging.This sharpens the original finding rather than softening it. The
cargo test -p t27cstep was added to a workflow outside the required set, so even had it been green it could never have blocked a merge. It was wrong on its numbers and wrong in its placement, and the second error would have outlived fixing the first.Not done here, on purpose
Adding
corpus-ratchetto the ruleset would makeW632 (BLOCKING)real — but it is currently failing on master, so requiring it would block every PR in the repo. That has to follow the ratchet in #2292, not precede it.Honesty limits
feat/wave-547/host-heapsort, not master; (2) "all pass, so land a plain gate" — on master it is 1602 passed / 13 failed; (3) "master has no branch protection" — read from an endpoint that cannot see rulesets. Each was a real command with real output, read as answering a question it did not answer.bypass_actors. "Protected" here means the rules are active, not that nobody can route around them.bootstrap/tests/still never ran), still tracked in cargo test -p t27c landed red on master: the 1221-pass measurement was taken on the wrong tree #2292 with suite.rs unit tests are compiled by nothing — 33 tests plus 3 new ones never type-checked #2288 and CI: t27c's 1221 tests have never run on master — land the gate (fixes #2288) #2289 reopened.docs/NOW.mdgains 84 lines and loses 0; the false text stays below as history with the retraction above it, per this repo's convention for that file.