fix(gen-verilog): nested struct field access resolves to one cumulative part-select - #2248
Merged
Conversation
Self-audit over the first full-green master run found three jobs that were green while verifying nothing, each confirmed by two independent refutation passes. fpga-formal: .sby files used indented pseudo-blocks sby does not parse (the bmc task saw no [engines] and died before any solver), [files] paths escaped the workspace, the 'if sby|tee' tested tee without pipefail so PASS was unconditional, and continue-on-error capped the job green over everything. fpga-conformance: bare -g2005 compiled 0 of 32 testbenches and the failure was a warning; the 'CLEAN' verdict in the summary is a static JSON field echoed as if computed (vvp lane: #2241). fpga-lint: the repo's own readiness tool printed NOT READY and exited 0; 1/32 invalid Verilog was a warning. All four now fail when they find nothing: canonical per-line sby task conditionals with local paths, pipefail + no continue-on-error + FAIL fails the step, -g2012 -DSIMULATION + exit 1, lint exit 1, synth-readiness bails on NOT READY. The expected honest red on lint has a named cause: a live gen-verilog regression (#2240) that the warning-gate absorbed within 40 minutes of the 32/32 claim. Closes #2239.
…umulative part-select state.flags.empty emitted 'state[96 +: 4]_empty' -- the ExprFieldAccess branch matched identifier, index and call bases but not a field-access base, so the chain fell through to name-flattening and glued an identifier fragment onto a part-select (fifo.v, 6 sites, invalid Verilog live on master; absorbed for 40 minutes by the old warning-only lint gate). The chain now resolves to a single cumulative part-select: state[96 +: 1] for flags.empty, state[97 +: 1] for flags.full. Signed fields keep the $signed() wrap on rvalue reads. M5 performed. Negative controls: zero glued sites in regenerated fifo.v; yosys parses it; the full 32-module smoke set lints 32/32 with the repo's own flags. Closes #2240.
gHashTag
enabled auto-merge (squash)
August 19, 2026 19:20
This was referenced Aug 19, 2026
…rtselect # Conflicts: # docs/NOW.md
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
Contributor
PR DashboardGenerated at: 2026-08-19 20:19:28 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2240. The live regression behind the expected honest-red lint: a field-access base fell through to name-flattening and glued an identifier fragment onto a part-select. Chain now resolves to a cumulative part-select; 0 glued sites, yosys parses fifo.v, full smoke set 32/32 — the honest gates from #2242 can be green for real. M5 performed. docs/NOW.md updated.
🤖 Generated with Claude Code