explain how to bump deps, and cut to rv - #192
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
README and devcontainer setup instructions contain unresolved rv and Ruby configuration documentation issues.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates development dependencies, pins Node.js to v24.21.0, and revises Ruby setup documentation to use rv.
Changes:
- Upgrades HTML validation and checker dependencies.
- Updates dependency lockfiles and package metadata.
- Revises local setup and maintenance instructions.
- Clarifies runtime versioning in the devcontainer.
File summaries
| File | Summary |
|---|---|
yarn.lock |
Locks updated JavaScript dependencies. |
README.md |
Updates setup and maintenance guidance; remaining rv documentation issues need correction. |
package.json |
Updates development dependency ranges. |
.node-version |
Pins Node.js to v24.21.0. |
.devcontainer/devcontainer.json |
Documents runtime versioning; the stale rbenv reference should be updated to rv. |
Review details
Suppressed comments (3)
README.md:104
- This step rewrites the tracked
.ruby-versionfile, which CI consumes atbuild-test-deploy.yml:30; onlyGemfile.lockis ignored. Saying there is no PR for this can cause contributors to leave CI and local Ruby pins out of sync, so explicitly tell them to commit.ruby-versionwhen it changes.
2. Get updated Ruby + gems GitHub Pages uses, no PR for this, the lock file is git-ignored
README.md:20
- This replacement removes the previous Mac-only qualifier and makes Homebrew the only manual Ruby setup path, even though this section is presented as the general non-container setup. Users on Linux or Windows may not have
brew; document rv's supported installation path for those platforms or retain a platform-neutral alternative.
1. Install Ruby and gems to match GitHub Pages versions:
```sh
brew install rv # uses .ruby-version
README.md:22
brew install rvonly installs the manager, and the onerv run bundle installinvocation does not persist Ruby selection for later commands. The documentedyarn build/yarn devscripts callbundle execdirectly (package.json:48-50), so a fresh shell can run the system Ruby and fail to findgithub-pages; initialize rv's shell integration here or route those commands throughrv run.
brew install rv # uses .ruby-version
rv ruby install
rv run bundle install
- Files reviewed: 4/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| { | ||
| "name": "Jekyll", | ||
| "image": "mcr.microsoft.com/devcontainers/ruby:3.3-bookworm", // We want 3.3.4 exactly but let's try this | ||
| "image": "mcr.microsoft.com/devcontainers/ruby:3.3-bookworm", // Minor tag (3.3) must match .ruby-version. This image does not pin the patch; CI and rbenv do. |
Comment on lines
+20
to
+21
| brew install rv # uses .ruby-version | ||
| rv ruby install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.