feat: gate new Cargo publication metadata - #340
Draft
JulianRuiseco wants to merge 1 commit into
Draft
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Require explicit approval before a crate becomes metadata-marked for Cargo publication, and detect approved crates that are still absent from the target registry.
Solution
Add
check-cargo-publish-policywith separate approval and registry modes. It reads committed Cargo manifests from Git objects, fails closed on invalid metadata or registry responses, and treats a crate name as present regardless of version or yank state.The command never publishes. Tagged releases continue to check exact dependency versions, publish missing dependencies before dependants, and skip a dependant if its dependency fails.
Testing
RUSTC_WRAPPER= cargo test: 307 passedRUSTC_WRAPPER= cargo clippy --all-targets -- -D warningsRUSTC_WRAPPER= cargo checkcargo +nightly fmt --all -- --checkfsl_libsbase and head with--check approval: no newly marked packagesRollout
Release this as v2.48.2 before enabling the dependent
fsl_libsworkflow or Prow registry policy job.