Add app icon at repo-root favicon.svg for Conductor - #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a top-level
favicon.svgso Conductor can find and display reeve's app icon.Of Conductor's search paths, no
public/directory exists (reeve is a Swift package, not a web app), so the repo-rootfavicon.svgis the highest-priority path that fits this layout. The icon reuses the existing brand mark fromsite/favicon.svg(the grey rounded-square "r" logo), which scales cleanly at any size.Summary by cubic
Add a repo-root
favicon.svgsoConductorcan find and display reeve’s app icon. Reuses thesite/favicon.svggray rounded-square “r” mark, placed at the top level since this Swift package has nopublic/directory.Written for commit 682c441. Summary will update on new commits.