Ignore build directory when verifying code regions#87
Open
Daniel1464 wants to merge 2 commits into
Open
Conversation
|
🌐 Preview URL: https://pr-87.frcsoftware.pages.dev |
samfreund
requested changes
Jul 16, 2026
samfreund
left a comment
samfreund
left a comment
Member
There was a problem hiding this comment.
Using path contains 'build' is fairly loose, it could include anything that has the word in it iirc. Prefer narrowing the check to a directory with the exact name of 'build'.
Contributor
Author
Would checking for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotless sometimes generates java files in the build directory in between runs, and these get resolved as unused code regions by the verifier script. This doesn't impact the CI, but it is a problem when trying to run lint on your local machine.