chore: raise the node floor to 20 - #32
Merged
Merged
Conversation
package.json declared `>=18` while the sibling skulk package declares `>=20`, so the two installers claimed different floors and their CI matrices tested different ends. Node 18 left maintenance in April 2025. The matrix follows the declaration: 20 and 24, the floor and the version the release workflow publishes with. The suite passes on both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.jsondeclared"node": ">=18"while the sibling skulk package declares">=20". Two installers that share a design and a release path claimed different floors, and their CI matrices tested different ends of that range.Node 18 left maintenance in April 2025.
engines.node→>=20[20, 24], the declared floor and the version the release workflow publishes withVerified locally: 14/14 on node 20, 14/14 on node 24. The suite also still passed on 18, so nothing here is forced by a real incompatibility — it aligns the declaration with the version this package is actually maintained against.