Skip to content

🛡️ Sentinel: [HIGH] Fix missing deserialization sinks in taint tracking #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tachyon-beep wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: [HIGH] Fix missing deserialization sinks in taint tracking #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wardline/scanner/rules/untrusted_to_deserialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,10 @@ def _has_literal_true_kw(call: ast.Call, name: str) -> bool:
"@trusted(level='ASSURED')\ndef f(p):\n blob = validate(read_raw(p))\n"
" obj = pickle.loads(blob)\n return blob",
# numpy.load without allow_pickle=True is safe by default (no object unpickling).
# We must not return its result directly to avoid a PY-WL-101 finding, as numpy.load
# is a serialization sink shedding validation provenance.
Comment on lines 129 to +131
"@external_boundary\ndef read_raw(p):\n return p\n"
"@trusted(level='ASSURED')\ndef f(p):\n return numpy.load(read_raw(p))",
"@trusted(level='ASSURED')\ndef f(p):\n numpy.load(read_raw(p))\n return 'safe'",
),
)

Expand Down
6 changes: 6 additions & 0 deletions src/wardline/scanner/taint/variable_level.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@
"tomllib.load",
"tomli_w.dumps",
"tomli_w.dump",
"dill.load",
"dill.loads",
"jsonpickle.decode",
"joblib.load",
"torch.load",
"numpy.load",
}
)

Expand Down