⚡ Bolt: Optimize AST traversal memory allocation - #137
Conversation
- Changed `_assignment_callee` and `_collect_return_paths` to take `Iterable[ast.AST]` instead of `list[ast.AST]` - Pass generators like `ast.iter_child_nodes()` directly instead of eagerly casting them to lists - Added a learning to `.jules/bolt.md` about avoiding eager generator evaluation during AST walks Co-authored-by: tachyon-beep <544926+tachyon-beep@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Changed the AST traversal functions
_assignment_calleeand_collect_return_pathsto acceptIterable[ast.AST]instead oflist[ast.AST], and passed theast.iter_child_nodes()generator directly instead of eagerly evaluating it into a list.🎯 Why: Eagerly materializing the generator into a list allocates memory unnecessarily for every node during recursive AST traversal, leading to increased memory overhead during code analysis.
📊 Impact: Reduces memory overhead when parsing and traversing deep/complex ASTs.
🔬 Measurement: Verify by running the full test suite and checking overall memory consumption on large files.
PR created automatically by Jules for task 804293250220878144 started by @tachyon-beep