fix(tooling): exit non-zero when refresh-stdlib or the test suite fails (#122) - #125
Merged
Merged
Conversation
…ls (#122) Nostrand.Main is void and never sets an exit code, so a task can only fail by throwing. refresh-stdlib caught each compile failure and carried on, and test/all just returned the run-tests summary, so both exited 0 and the CI test step could not fail. check-drift misses a failed refresh too, since a namespace that was never recompiled produces no byte difference. refresh-stdlib now throws before the copy step, leaving the committed DLLs untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122
refresh-stdlibcollects compile failures and throws before the copy step, so the committed DLLs stay untouched.test/allandtest/runthrow when the summary reports failures, so a red suite now failsbb test.