fix(nostrand): read a coord the way cljr canonicalizes it - #110
Merged
Conversation
nos read coords more narrowly than clr.tools.deps, so a deps-clr.edn written the community way silently resolved a different classpath. Coords now canonicalize like tools.deps: inferred :git/url, legacy :sha and :tag, :deps/root, :local/root relative to its deps file, :exclusions. An uninferable git url throws as cljr does, and alias keys nos ignores warn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109
canonicalizestep mirroringclojure.tools.deps.extensions.git::git/urlinferred from a hosted-service lib name (io.github.user/repoand the gitlab, bitbucket, beanstalk and sourcehut equivalents) for coords already pinned by sha or tag, and the legacy:shaand:tagspellings folded into:git/shaand:git/tag. Carrying both spellings of either throws, as incljr, and so does a git url that can be neither read nor inferred.:deps/rootlocates a git dependency's deps file and paths in that subdirectory of the checkout, a relative:local/rootresolves against the directory of the deps file that declared it, and a coord's:exclusionsprune the named libs from its subtree.cljrhonours andnosignores warn on stderr::deps,:paths,:replace-deps,:replace-paths,:default-depsand:classpath-overrides.nosskipped before are now cloned, so one that is unreachable or wrongly pinned fails at resolution instead of silently.