Add AWS CodeCommit URL parsing logic - #1277
Open
vocarista wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kumar Piyush <kr.piyush888@gmail.com> Assisted-by: Antigravity/Claude-Sonnet-4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR exports
ParseCodeCommitURLinauth/awsto provide a central helper for parsing AWS CodeCommit HTTPS Git URLs into host, region, and repository components.Currently, downstream consumers (such as
flux-operator) maintain duplicate CodeCommit URL parsing logic to extract host and repository details alongside the region. Centralizing this parsing influxcd/pkg/auth/awsallows callers to share a single parser.Changes
ParseCodeCommitURL(rawURL string) (host, region, repo string, err error)supporting standard, FIPS, and China partition URLs.getRegionFromCodeCommitURLto delegate toParseCodeCommitURLwhile preserving its existing function signature and error contracts.TestParseCodeCommitURLcovering positive, negative, and edge cases.Part of: controlplaneio-fluxcd/flux-operator#987