Skip to content

emergency label processing for unified check run#5110

Merged
auto-submit[bot] merged 7 commits into
flutter:mainfrom
ievdokdm:189729-emergency
Jul 24, 2026
Merged

emergency label processing for unified check run#5110
auto-submit[bot] merged 7 commits into
flutter:mainfrom
ievdokdm:189729-emergency

Conversation

@ievdokdm

@ievdokdm ievdokdm commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@ievdokdm
ievdokdm requested a review from jtmcdole July 22, 2026 01:54
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 22, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jul 22, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the unified check run flow by splitting the single check run guard into two distinct checks: dashboardChecks and mergeQueueGuard. This change propagates through multiple models, services, request handlers, and tests. Additionally, emergency unlocking is updated to only unlock the merge queue guard. A review comment points out that in scheduler.dart, the log message in _closeSuccessfulTestStage hardcodes CiStage.fusionTests even though the method is also called for CiStage.genericTests, and suggests using a more generic log message.

Comment thread app_dart/lib/src/service/scheduler.dart Outdated
@ievdokdm
ievdokdm requested a review from eyebrowsoffire July 22, 2026 15:58
eyebrowsoffire
eyebrowsoffire approved these changes Jul 23, 2026
View reviewed changes

@eyebrowsoffire eyebrowsoffire left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 24, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 24, 2026
@auto-submit

auto-submit Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/cocoon/5110, Failed to merge flutter/cocoon/5110 with Pull request flutter/cocoon/5110 could not be merged: Merge already in progress.

@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 24, 2026
@auto-submit
auto-submit Bot merged commit b1b4ac2 into flutter:main Jul 24, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes
@jtmcdole jtmcdole Awaiting requested review from jtmcdole
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unified check runs skipped after applying emergency label

2 participants

@ievdokdm @eyebrowsoffire