Support natural language offsets - #123
Merged
Merged
Conversation
jeromedalbert
force-pushed
the
add-nat-offset
branch
6 times, most recently
from
July 9, 2026 18:17
84f33da to
6b58267
Compare
Member
|
Salut, thanks for the PR, looking good, let me sleep and marinate over it... |
jeromedalbert
force-pushed
the
add-nat-offset
branch
from
July 10, 2026 07:51
6b58267 to
7f9533e
Compare
Contributor
Author
|
Merci pour ta considération et pour cette gem très utile que j'utilises depuis des années ! Some extra info:
|
jeromedalbert
force-pushed
the
add-nat-offset
branch
2 times, most recently
from
July 10, 2026 10:09
a168d40 to
113fded
Compare
jeromedalbert
force-pushed
the
add-nat-offset
branch
from
July 10, 2026 10:12
113fded to
55e7da8
Compare
Member
|
Salut, I'm taking it in, I might tweak it a little bit, but overall I like your work. Merci beaucoup ! |
jmettraux
added a commit
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At work we have a cron job that runs every 15 minutes (minutes 0, 15, 30, 45). The corresponding natural language expression is easy to write:
every 15 minutes.But we also have a second job that runs 1 minute after the first job (minutes 1, 16, 31, 46). There is currently no nice way to express this in natural language besides listing all the minutes:
at minutes 1,16,31,46.I thought it might be nice if the natural language parser could support offsets, so the second job's schedule could be rewritten to
every 15 minutes starting at minute 1orevery 15 minutes from minute 1.This PR is an attempt to support such offsets. If this looks useful, I am happy to tweak this further. For example I sort of like the expressiveness of "starting at", but it might look too wordy.