Add support for older F2000/767 firmware version - #64
Open
impala454 wants to merge 4 commits into
Open
Conversation
Owner
|
The new constructs in #61 should be able to make the commands and bit mangling a lot cleaner, with any luck that will be merged soon and it will be possible to take advantage of it. |
Author
|
I took a look at #61 and seems like a good change but this older firmware is so completely different I don't think it would change this PR. There is no negotation, no multi part packets, and the parsing is fixed fields, so I would probably still be overriding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in support for the older model F2000/767 firmware. This firmware is not upgradable to the latest and has a completely different scheme with no handshakes or negotiation. This PR adds almost all of the functionality the Anker app has to offer to this library. The only minor edit to the base class was just to allow for the different UUIDs needed and still maintain inheritance.