fix(server): block private IPs on custom proxy and mempoolrpc URLs - #193
Open
SashaMIT wants to merge 1 commit into
Open
fix(server): block private IPs on custom proxy and mempoolrpc URLs#193SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
The intentional ?url= BYO-proxy feature accepted arbitrary http(s) targets with no host validation, so loopback/link-local/RFC1918/CGNAT addresses were reachable and response bodies reflected. Validate scheme and resolved addresses before proxying; re-check redirects; apply the same gate to mempoolrpc. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?url=intentionally lets users BYO an upstream JSON-RPC proxy, but the target was not validated (scheme / host / resolved IP).http/httpsonly + reject blocked resolved addresses before setting the proxy; re-validate redirect hops; apply the same check tomempoolrpc.Test plan
go test ./server/(includes newValidateOutboundRPCURLcases + existing handler/url_params tests)?url=http://127.0.0.1/http://169.254.169.254→ 400; public HTTPS proxy still worksMade with Cursor