Stabilize room API integration tests against backend default webhook URLs#89
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job test (3.11)
Stabilize room API integration tests against backend default webhook URLs
Jul 22, 2026
PiotrWodecki
approved these changes
Jul 22, 2026
PiotrWodecki
marked this pull request as ready for review
July 22, 2026 12:52
czerwiukk
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test (3.11)GitHub Actions job was failing becausetests/test_room_api.pyassumed rooms created without an explicit webhook would always returnwebhook_url=None. In CI, the backend can inject a default webhook URL, causingRoomConfigequality assertions to fail.Root cause
TestCreateRoom.test_no_paramsTestCreateRoom.test_valid_paramsTestGetRoom.test_validRoomConfigand hard-codedwebhook_url=None, even though the backend may return a configured default URL.Change
webhook_url=Noneexpectation with the webhook URL actually returned on the created room:webhook_url=room.config.webhook_urlEffect