Release v0.29.0#88
Merged
Merged
Conversation
- Use the new PeerConfigWebRTC/PeerConfigAgent/PeerConfigVAPI models (PeerConfig was split per peer type in the regenerated OpenAPI client). - Connect agents via the peer_websocket_url returned by add_peer: on deployments with a separate media node the agent socket no longer lives on the Fishjam URL. Falls back to the old URL when the field is absent.
Contributor
There was a problem hiding this comment.
Pull request overview
Release bump to v0.29.0, updating the SDK to match regenerated OpenAPI client changes (notably the PeerConfig split) and adjusting agent connection behavior for Fishjam ≥0.29 media-node websocket routing.
Changes:
- Bumped project/version metadata to
0.29.0. - Updated SDK peer creation code to use the new OpenAPI-generated
PeerConfigWebRTC/PeerConfigAgent/PeerConfigVAPImodels and to derive agent websocket base URL frompeer_websocket_url. - Regenerated OpenAPI client artifacts (new recordings endpoints/models, updated response handling, updated peer config typing).
Reviewed changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Bumps locked package version to 0.29.0. |
| pyproject.toml | Bumps project version to 0.29.0. |
| tests/agent/test_agent.py | Updates invalid-auth test to connect to a real socket route before failing auth. |
| fishjam/api/_fishjam_client.py | Adapts peer/agent creation to new PeerConfig models; derives websocket base URL from peer_websocket_url. |
| fishjam/agent/agent.py | Stores base URL used to build agent websocket URL. |
| fishjam/_openapi_client/models/stream_config.py | Updates webhook_url docstring to mark it deprecated in favor of Dashboard config. |
| fishjam/_openapi_client/models/room_config.py | Updates webhook_url docstring to mark it deprecated in favor of Dashboard config. |
| fishjam/_openapi_client/models/recording.py | Adds generated Recording model. |
| fishjam/_openapi_client/models/recording_status.py | Adds generated RecordingStatus enum. |
| fishjam/_openapi_client/models/recording_metadata_type_0.py | Adds generated recording metadata model. |
| fishjam/_openapi_client/models/recording_list_response.py | Adds generated response model for listing recordings. |
| fishjam/_openapi_client/models/recording_details_response.py | Adds generated response model for recording details. |
| fishjam/_openapi_client/models/recording_config.py | Adds generated model for creating recordings. |
| fishjam/_openapi_client/models/recording_config_metadata_type_0.py | Adds generated recording config metadata model. |
| fishjam/_openapi_client/models/peer_config.py | Removes legacy unified PeerConfig model (replaced by split variants). |
| fishjam/_openapi_client/models/peer_config_web_rtc.py | Adds generated PeerConfigWebRTC model. |
| fishjam/_openapi_client/models/peer_config_web_rtc_type.py | Adds generated PeerConfigWebRTCType enum. |
| fishjam/_openapi_client/models/peer_config_vapi.py | Adds generated PeerConfigVAPI model. |
| fishjam/_openapi_client/models/peer_config_vapi_type.py | Adds generated PeerConfigVAPIType enum. |
| fishjam/_openapi_client/models/peer_config_agent.py | Adds generated PeerConfigAgent model. |
| fishjam/_openapi_client/models/peer_config_agent_type.py | Adds generated PeerConfigAgentType enum. |
| fishjam/_openapi_client/models/list_recordings_metadata.py | Adds generated metadata filter model for recordings list endpoint. |
| fishjam/_openapi_client/models/composition_source.py | Adds generated composition source model used by recordings. |
| fishjam/_openapi_client/models/init.py | Updates model exports to include new peer config + recordings models. |
| fishjam/_openapi_client/api/track_forwardings/create_track_forwarding.py | Adds 409 response parsing. |
| fishjam/_openapi_client/api/streams/create_stream.py | Adds 402 response parsing. |
| fishjam/_openapi_client/api/rooms/add_peer.py | Updates add-peer body typing for split PeerConfig variants. |
| fishjam/_openapi_client/api/recordings/list_recordings.py | Adds recordings list endpoint implementation. |
| fishjam/_openapi_client/api/recordings/get_recording.py | Adds recordings get endpoint implementation. |
| fishjam/_openapi_client/api/recordings/delete_recording.py | Adds recordings delete endpoint implementation. |
| fishjam/_openapi_client/api/recordings/create_recording.py | Adds recordings create endpoint implementation. |
| fishjam/_openapi_client/api/recordings/init.py | Adds recordings API package init. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
czerwiukk
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the version to
0.29.0as part of the release process.Changes
0.29.0(automation commit, includes regenerated OpenAPI client + protos pointer)protossubmodule tov0.29.0peer_websocket_url