Support 64-bit integer builds#5259
Merged
Merged
Conversation
leo-collins
commented
Jul 16, 2026
leo-collins
commented
Jul 16, 2026
leo-collins
commented
Jul 16, 2026
connorjward
requested changes
Jul 16, 2026
fixes
leo-collins
force-pushed
the
leo/64bit-int
branch
from
July 16, 2026 12:58
888557b to
0953524
Compare
* function struct use PetscInt * use correct petsc types * fix header * fix to legacy .at fix * use PetscInt fix * use correct mpi type for permutation * use blas int * use dtype * type fixes use size_t for ncells_ignore use size_t for loops over ignored cells locator now returns int since it is an error code * relax assertions in adjoint test This was very flaky Add additional assertions to test that the transformed reduced functional converges faster * Update firedrake/mesh.py Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk> --------- Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk>
connorjward
approved these changes
Jul 22, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support builds with 64-bit integers.
--int-typeoption tofiredrake-configure. Users can pass--int-type int64for a 64-bit integer build